[llvm] 094c0ec - Avoid fallthrough after ffb109b6852d248c9d2e3202477dccf20aac7151

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 22:05:17 PST 2022


Author: Jordan Rupprecht
Date: 2022-11-10T22:05:09-08:00
New Revision: 094c0eccdf959c3b9c85219e33c3fcfbab024b61

URL: https://github.com/llvm/llvm-project/commit/094c0eccdf959c3b9c85219e33c3fcfbab024b61
DIFF: https://github.com/llvm/llvm-project/commit/094c0eccdf959c3b9c85219e33c3fcfbab024b61.diff

LOG: Avoid fallthrough after ffb109b6852d248c9d2e3202477dccf20aac7151

Fallthrough appears to be not intended here, as otherwise this is a completely dead store: `DOPRegIsUnique` will be overwritten by the next case.

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp b/llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
index 7bfb8c8f3c8b..e903c52fead7 100644
--- a/llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
@@ -492,6 +492,7 @@ bool AArch64ExpandPseudo::expand_DestructiveOp(
   switch (DType) {
   case AArch64::DestructiveBinary:
     DOPRegIsUnique = DstReg != MI.getOperand(SrcIdx).getReg();
+    break;
   case AArch64::DestructiveBinaryComm:
   case AArch64::DestructiveBinaryCommWithRev:
     DOPRegIsUnique =


        


More information about the llvm-commits mailing list