[PATCH] D137813: [RegAlloc Greedy]Account statepoints while splitting single basic block

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 21:02:17 PST 2022


skatkov added inline comments.


================
Comment at: llvm/lib/CodeGen/StackMaps.cpp:154
+      break;
+    if (MO.isReg() && MO.getReg() == Reg)
+      return false;
----------------
arsenm wrote:
> skatkov wrote:
> > arsenm wrote:
> > > Do you need to account for subregisters?
> > It is about virtual registers. I think no.
> Only virtual registers have subregisters 
Well, I go to learn about statepoint and sub-registers. Still think I do not need but need to prove :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137813/new/

https://reviews.llvm.org/D137813



More information about the llvm-commits mailing list