[PATCH] D137813: [RegAlloc Greedy]Account statepoints while splitting single basic block
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 10 20:42:38 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/SplitKit.cpp:1584
+ if ((FI->getOpcode() != TargetOpcode::STATEPOINT) &&
+ (LI->getOpcode() != TargetOpcode::STATEPOINT))
+ return SlotIndex();
----------------
Early exit after the first one?
================
Comment at: llvm/lib/CodeGen/StackMaps.cpp:151
+ unsigned FoldableAreaStart = getVarIdx();
+ for (const MachineOperand &MO : MI->uses()) {
+ if (MI->getOperandNo(&MO) >= FoldableAreaStart)
----------------
Do you need to filter out implicit-defs? uses doesn't
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137813/new/
https://reviews.llvm.org/D137813
More information about the llvm-commits
mailing list