[PATCH] D137542: [AMDGPU] Use aperture registers instead of S_GETREG

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

How have you tested this? OpenCL conformance flat tests with -O0 and -O2 should be good enough



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1830
+    MRI.setRegClass(Tmp, &AMDGPU::SReg_64_XEXECRegClass);
+    B.buildInstr(AMDGPU::S_MOV_B64).addDef(Tmp).addReg(Register(ApertureRegNo));
+    return B.buildUnmerge(S32, Tmp).getReg(1);
----------------
You can just build a copy at this point. We should use copies and mark it as a constant register 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137542/new/

https://reviews.llvm.org/D137542