[PATCH] D135427: [LTO] Make local linkage GlobalValue in non-prevailing COMDAT available_externally

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:1166
+        continue;
+      assert(isa<GlobalValue>(GA.getAliasee()) &&
+             "non-GlobalValue aliasee is unimplemented");
----------------
aeubanks wrote:
> we're hitting this assert in a bootstrap build of clang with ThinLTO on windows: https://crbug.com/1382839
How is the non-GlobalValue currently used? This feature in a COMDAT was not properly supported...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135427/new/

https://reviews.llvm.org/D135427