[PATCH] D137628: [LoongArch] Implement MCTargetExpr::fixELFSymbolsInTLSFixups hook

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

This should use an assembly test at MC layer (llvm/test/MC)



================
Comment at: llvm/test/CodeGen/LoongArch/tls-symbols.ll:1
+; RUN: llc --mtriple=loongarch64 --relocation-model=pic --filetype=obj < %s \
+; RUN:     -o - | llvm-readelf -s - | FileCheck %s
----------------
remove `< `


================
Comment at: llvm/test/CodeGen/LoongArch/tls-symbols.ll:12
+entry:
+; CHECK: TLS{{.*}}UND unspecified
+  ret ptr @unspecified
----------------
It's better to use 

`CHECK-DAG` to leave flexibility for MC to order symbol tables in another way. The symbol order is not guaranteed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137628/new/

https://reviews.llvm.org/D137628