[PATCH] D136524: [InstCombine] Handle select inst when eliminating constant memcpy

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:326
+                                     getReplacement(SI->getTrueValue()),
+                                     getReplacement(SI->getFalseValue()));
+    IC.InsertNewInstWith(NewSI, *SI);
----------------
IC.InsertNewInstWith should take care of debug info, but you're dropping any other instruction metadata that was attached 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136524/new/

https://reviews.llvm.org/D136524