[PATCH] D137434: [lit] Add `target=<triple>` as a feature keyword

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 10:09:15 PST 2022


probinson added a comment.

In D137434#3918419 <https://reviews.llvm.org/D137434#3918419>, @dblaikie wrote:

> Any chance this could be put in one place/shared across all LLVM projects, rather than duplicated in subprojects (the thread mentions this is already in libcxx, for instance - be nice to put it in one place so everyone gets it? (does this patch make the libcxx feature redundant/could it be removed?))

This patch does cause `target=<triple>` to be shared across all LLVM projects.  The code in libcxx to define the same thing is harmlessly redundant and could be removed; I do plan to get to that eventually, if @ldionne doesn't beat me to it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137434/new/

https://reviews.llvm.org/D137434



More information about the llvm-commits mailing list