[PATCH] D137672: [LoopFuse] Ensure inner loops are in loop simplified form under new PM

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 09:19:02 PST 2022


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

description nit: `LI` doesn't give you loop nests, it gives you top level loops

lg with test and description fixes



================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:37
+
+; RUN: opt < %s -passes=loop-fusion -S | FileCheck %s
+
----------------
there's already a RUN at the top


================
Comment at: llvm/test/Transforms/LoopFusion/ensure_loop_simplify_form.ll:66
+for.cond42.preheader.i.i:                         ; preds = %for.body37.i.i
+  br i1 poison, label %for.body44.i.i, label %for.end47.i.i
+
----------------
this is UB, can you replace these with a constant like `true`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137672/new/

https://reviews.llvm.org/D137672



More information about the llvm-commits mailing list