[PATCH] D137723: [PDB] Don't include input files in the 'cmd' entry of S_ENVBLOCK

Sylvain Audi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 08:40:37 PST 2022


saudi added inline comments.


================
Comment at: lld/COFF/PDB.cpp:1357
   for (StringRef a : args) {
+    if (!a.startswith("/") && !a.startswith("-"))
+      continue;
----------------
thakis wrote:
> What if I'm cross-linking on Linux and passing in /path/to/foo.o?
Indeed, I can't make the assumption that any argument starting with `/` is an input file.
I'll investigate more to get a posix-friendly version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137723/new/

https://reviews.llvm.org/D137723



More information about the llvm-commits mailing list