[PATCH] D133116: [AArch64][SVE] Optimise repeated floating-point complex patterns to splat

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

One suggestion inline.

Accepting to remove my block and encourage other reviewers to weigh in if they have problems with the approach. Please hold off submission until late Monday as I would like to do one more pass over it before we push.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20700
+  EVT VecElTy = VecTy.getScalarType();
+  if (VecElTy == MVT::f64 || VecElTy == MVT::i64 || VecElTy == MVT::i8)
+    return SDValue();
----------------
Would it be better to express this condition in terms of 'if (VecElTy not in (set of supported types))` so that it's impossible for new types to arise which would be broken? (Also makes it read as an explicit gate of supported types).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133116/new/

https://reviews.llvm.org/D133116