[PATCH] D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 06:30:54 PST 2022


dp added a comment.

> For some reason SP3 additionally accepts TFE forms with vN VData operands where v[N:N+1] is expected, so for example `buffer_load_dword v1, v0, s[4:7], s1 glc tfe` and `buffer_load_dword v[1:2], v0, s[4:7], s1 glc tfe` are both accepted and produce same opcodes. It should be possible to support that with a separate change, if needed.

I think we do not have to support this SP3 feature.

> Apart from that, https://reviews.llvm.org/D19584 mentions that use of `off` operands agrees with SP3. I wasn't able to find any signs in SP3 behaviour confirming this.

Unfortunately, SP3 is not consistent in accepting 'off' for unused operands. It does support `off` for FLAT operands, but not for MUBUF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137783/new/

https://reviews.llvm.org/D137783



More information about the llvm-commits mailing list