[PATCH] D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass.

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:666
+                            SmallVectorImpl<CallSpecBinding> &Specializations) {
+  SmallVector<CallBase *, 8> CallSitesToRewrite;
+  for (User *U : F->users())
----------------
labrinea wrote:
> There might be more call sites to rewrite than those in the CallSpecBinding that we have already found, therefore we need to repeat this look up of users here, but at least it now happens once for F compared to Clones.size() times which was the case before.
Use braces around the `for`,  since there are more than two levels of nesting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126455/new/

https://reviews.llvm.org/D126455