[PATCH] D136663: Handling ADD|SUB U64 decomposed Pseudos not getting lowered to SDWA form

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 02:07:52 PST 2022


yassingh updated this revision to Diff 474481.
yassingh added a comment.

Since only v_add_co_u32_e32 can be converted to SDWA form there is no need to try convert v_addc_co_u32_e64 to it's VOP2 form. This will allow us to get rid of all the checks we were performing on v_addc_co_u32. The shrinking of this instr will be taken care by si-shrink-instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136663/new/

https://reviews.llvm.org/D136663

Files:
  llvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
  llvm/test/CodeGen/AMDGPU/sdwa-ops.mir
  llvm/test/CodeGen/AMDGPU/v_add_u64_pseudo_sdwa.ll
  llvm/test/CodeGen/AMDGPU/v_sub_u64_pseudo_sdwa.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136663.474481.patch
Type: text/x-patch
Size: 7299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221110/87b8f78a/attachment.bin>


More information about the llvm-commits mailing list