[PATCH] D137655: Expand fminimum and fmaximum into a pair of selects

Thu Nov 10 01:46:22 PST 2022

gflegar added a comment.

In D137655#3917359 <https://reviews.llvm.org/D137655#3917359>, @nikic wrote:

> I don't think this is right either. LLVM defines minnum according to the old semantics, which don't specify an order between zeroes. We'd need a separate ISD opcode for minnum according to 2018 semantics.

Interestingly though, for the NVPTX backend this will end up producing the correct code, since minnum is lowered to the min/max PTX instructions, which defines the 2018 semantics. (I do agree though that the intermediate code is not correct.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137655/new/

https://reviews.llvm.org/D137655