[PATCH] D137758: [HardwareLoops] remove loops which has undef count

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:158
     bool MadeChange = false;
+    SmallVector<Loop *, 1> DeadLoops;
   };
----------------
nit: I'd prefer that these were references.


================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:247
+    // Set incoming value to poison for phi nodes in the exit block.
+    for (PHINode &P : ExitBlock->phis()) {
+      std::fill(P.incoming_values().begin(), P.incoming_values().end(),
----------------
I see the same logic is used in `LoopDeletion`, so should this be factored out into `deleteDeadLoop`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137758/new/

https://reviews.llvm.org/D137758