[PATCH] D137689: [AArch64] Select BFI/BFXIL to ORR with shifted operand when one operand is the left or right shift of another operand

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:2945
+      SDValue Ops[] = {OrOpd1, OrOpd1,
+                       CurDAG->getTargetConstant(ShlImm, DL, VT)};
+      CurDAG->SelectNodeTo(N, OrrOpc, VT, Ops);
----------------
Should this go through getShifterImm, for consistency even if LSL == 0?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137689/new/

https://reviews.llvm.org/D137689