[PATCH] D135402: [LLD] Enable --no-undefined-version by default.

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 12:19:53 PST 2022


jhuber6 added a comment.

In D135402#3917463 <https://reviews.llvm.org/D135402#3917463>, @JonChesterfield wrote:

> So I'm inclined to say we should pass `-Wl,--undefined-version` through CMake, optimistically hoping that ld will ignore flags it doesn't understand and/or there is some mechanism to pass different flags to different linkers in CMake, at which point the openmp side of things will stop falling over. Maybe the same workaround is legitimate for lto export

That was the original approach, but this didn't work out as the GNU linker doesn't ignore those and I don't think there's a way to configure CMake based off of the linker. Users are free to configure clang to use whatever linker by default, and we don't necessarily know if the compiler is clang. I'm not very familiar with the `libomp` code, but we could potentially just export a wildcard and accept a few new symbols leaking out in different configuraitons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135402/new/

https://reviews.llvm.org/D135402



More information about the llvm-commits mailing list