[PATCH] D136599: [amdgpu][lds] Use the same isKernel predicate consistently

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

OK, so this can't be cleanly factored out as in this patch, and the current behaviour is broken for IR which mixes amdgpu_kernel and shaders. LowerModuleLDS groups functions into kernel and non-kernel, and rewrites uses from non-kernels, so if shaders are reclassified as non-kernels (which this patch effectively does) then uses from shaders get rewritten to the function style lowering, which definitely won't work for them.

Difficult to fix accurately if a function is callable from a shader and from a kernel and they use different lowering strategies for LDS. I think I'm going to leave the mixed-uses broken, i.e. ignore this for now, and try to persuade graphics to adopt the same lowering as compute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136599/new/

https://reviews.llvm.org/D136599