[PATCH] D137655: Expand fminimum and fmaximum into a pair of selects

[Goran Flegar via Phabricator via llvm-commits]

gflegar updated this revision to Diff 474267.
gflegar added a comment.

Change lowering to minnum/maxnum + NaN check

Also update the failing arm test to pass.
I'm not an expert on ARM, but looking at ARMISelLowering.cpp, it does
specify exactly under which conditions minimum / maximum instructions
are available. Thus, they also likely had the same silent failure
that the PTX side had, and the test was likely wrong (since the checks
were auto-generated).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137655/new/

https://reviews.llvm.org/D137655

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  llvm/test/CodeGen/ARM/fminmax-folds.ll
  llvm/test/CodeGen/NVPTX/fminimum-fmaximum.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137655.474267.patch
Type: text/x-patch
Size: 10005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221109/1ecbd2f1/attachment.bin>