[PATCH] D137093: [AArch64][SVE][NFC] Add streaming mode SVE tests

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for making the changes @hassnaa-arm.



================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-rev.ll:229
+; CHECK-NEXT:    ret
+  %res = call <2 x i16> @llvm.bswap.v2i16(<2 x i16> %op)
+  ret <2 x i16> %res
----------------
Wow, this code quality is impressively bad! :) I think we'd be better off just scalarising this and marking as EXPAND, but that's not a priority right now.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-splat-vector.ll:21
+; CHECK-NEXT:    ldr d0, [sp, #8]
+; CHECK-NEXT:    add sp, sp, #16
+; CHECK-NEXT:    ret
----------------
I think it's definitely worth trying to improve the codegen for these tests in a future patch because it's a common pattern and we know we can just use the SVE dup instructions for these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137093/new/

https://reviews.llvm.org/D137093