[PATCH] D137542: [AMDGPU] Use aperture registers instead of S_GETREG

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 06:09:20 PST 2022


foad added a comment.

In D137542#3917197 <https://reviews.llvm.org/D137542#3917197>, @Pierre-vh wrote:

> In D137542#3917196 <https://reviews.llvm.org/D137542#3917196>, @foad wrote:
>
>>> do we have to change the RC of the src_shared/private_base register to 64 bit?
>>
>> Yes that sounds right.
>>
>>> (ideally it should be available for both, no?)
>>
>> That would be useful bu apparently it's not how the hardware works. I guess it gives you the 32 low bits which is not very useful because it will always be 0 for src_*_base and -1 for src_*_limit.
>
> Which RegisterClass should I use for it? Just SGPR64?

I don't know. I'm not too familiar with that stuff. Can you copy what we do for SGPR_NULL64?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137542/new/

https://reviews.llvm.org/D137542



More information about the llvm-commits mailing list