[PATCH] D137411: [AArch64][SVE2] Add the SVE2.1 integer quadword reduction instructions

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 05:50:09 PST 2022


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:3701
+let Predicates = [HasSVE2p1_or_HasSME2p1] in {
+defm ORQV  : sve2p1_log_reduction_q<0b00, "orqv">;
+defm EORQV : sve2p1_log_reduction_q<0b01, "eorqv">;
----------------
david-arm wrote:
> paulwalker-arm wrote:
> > Please add the usual register suffixes, so `_VPZ` in this case?
> I just realised I forgot to add the suffixes. I can do that in a follow-up.
Thanks @david-arm, please remember to do this before landing the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137411/new/

https://reviews.llvm.org/D137411



More information about the llvm-commits mailing list