[PATCH] D137619: [AArch64][SVE2] Add the SVE2.1 permute vector elements (quadword) instructions

[David Sherwood via Phabricator via llvm-commits]

david-arm marked 2 inline comments as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:1086
 
-class sve2_clamp<string asm, bits<2> sz, bit U, ZPRRegOp zpr_ty>
-    : I<(outs zpr_ty:$Zd), (ins zpr_ty:$Zn, zpr_ty:$Zm, zpr_ty:$_Zd),
----------------
paulwalker-arm wrote:
> Not really against it but is there a good reason to move this code rather than adding you new `sve2p1_tblq` multiclass here instead?
As discussed privately, this is actually moving to a different file - SVEInstrFormats.td


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:9529
+multiclass sve2_clamp<string asm, bits<4> opc, SDPatternOperator op> {
+  // bits 13-11 = 0
+  def _B : sve2_permuteq_or_clamp<asm, 0b00, opc, ZPR8,  ZPR8>;
----------------
paulwalker-arm wrote:
> I don't think this comment means anything because those bits are passed in via `opc`.
My apologies - it was a stray comment I'd left in the code by mistake!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137619/new/

https://reviews.llvm.org/D137619