[PATCH] D137655: Expand fminimum and fmaximum into a pair of selects

Wed Nov 9 02:28:47 PST 2022

nikic added a comment.

In D137655#3916906 <https://reviews.llvm.org/D137655#3916906>, @gflegar wrote:

> In D137655#3915463 <https://reviews.llvm.org/D137655#3915463>, @nikic wrote:
>
>> Doesn't this handle signed zero incorrectly?
>
> I believe it is:
>
> For `FMINIMUM`:
>
>   Tmp1 = -0.0, Tmp2 = +0.0  =>  Tmp1 ULT Tmp2 == True   =>  Tmp3 = Tmp1 = -0.0;     Tmp2 UO Tmp2 = False  =>  Result = Tmp3 = -0.0

Isn't `-0.0 ULT 0.0` false, because negative zero and positive zero are equal?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137655/new/

https://reviews.llvm.org/D137655