[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Drop trailing period from subject.



================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1792
+// RUN: %clang -march=graniterapids -m32 -E -dM %s -o - 2>&1 \
+// RUN:     -target i386-unknown-linux \
+// RUN:   | FileCheck -match-full-lines %s -check-prefix=CHECK_GNR_M32
----------------
Prefer `--target=` to legacy `-target ` for new tests.

Consider refactoring the long `CHECK` lines to use delta encoding:

```
RUN: ... | FileCheck %s --check-prefixes=A
RUN: ... | FileCheck %s --check-prefixes=A,B
RUN: ... | FileCheck %s --check-prefixes=A,B,C
```

for better maintenance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137153/new/

https://reviews.llvm.org/D137153