[PATCH] D137651: [LoopFlatten] Forget all block and loop dispositions after flatten

[luxufan via Phabricator via llvm-commits]

StephenFan updated this revision to Diff 474167.
StephenFan retitled this revision from "[LoopFlatten] Forget SCEV block and loop dispositions for removed incomming values of phi" to "[LoopFlatten] Forget all block and loop dispositions after flatten".
StephenFan edited the summary of this revision.
StephenFan added a comment.
Herald added a subscriber: javed.absar.

Replace forgetting incoming values as forget all of the block and loop dispositions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137651/new/

https://reviews.llvm.org/D137651

Files:
  llvm/lib/Transforms/Scalar/LoopFlatten.cpp
  llvm/test/Transforms/LoopFlatten/pr58865.ll


Index: llvm/test/Transforms/LoopFlatten/pr58865.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/LoopFlatten/pr58865.ll
@@ -0,0 +1,28 @@
+; RUN: opt -loop-flatten -verify-scev < %s
+
+define void @sum_2d(ptr %p) {
+entry:
+  br label %outer
+
+outer:                                         ; preds = %outer.latch, %entry
+  %sum.04 = phi i16 [ 0, %entry ], [ %0, %outer.latch ]
+  %outer.iv = phi i16 [ 0, %entry ], [ %outer.iv.next, %outer.latch ]
+  br label %inner
+
+inner:                                        ; preds = %inner, %outer
+  %sum.12 = phi i16 [ %sum.04, %outer ], [ %0, %inner ]
+  %inner.iv = phi i16 [ 0, %outer ], [ %inner.iv.next, %inner ]
+  %0 = load i16, ptr %p, align 1
+  %inner.iv.next = add nsw i16 %inner.iv, 1
+  %cmp2 = icmp slt i16 %inner.iv, 0
+  br i1 %cmp2, label %inner, label %outer.latch
+
+outer.latch:                                         ; preds = %inner
+  %outer.iv.next = add nsw i16 %outer.iv, 1
+  %cmp = icmp slt i16 %outer.iv.next, 0
+  br i1 %cmp, label %outer, label %exit
+
+exit:                                         ; preds = %outer.latch
+  ret void
+
+}
Index: llvm/lib/Transforms/Scalar/LoopFlatten.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopFlatten.cpp
+++ llvm/lib/Transforms/Scalar/LoopFlatten.cpp
@@ -762,6 +762,7 @@
   // deleted, and any information that have about the outer loop invalidated.
   SE->forgetLoop(FI.OuterLoop);
   SE->forgetLoop(FI.InnerLoop);
+  SE->forgetBlockAndLoopDispositions();
   if (U)
     U->markLoopAsDeleted(*FI.InnerLoop, FI.InnerLoop->getName());
   LI->erase(FI.InnerLoop);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137651.474167.patch
Type: text/x-patch
Size: 1703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221109/5d4c7461/attachment.bin>