[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 22:12:56 PST 2022


tstellar added a comment.

In D137669#3916493 <https://reviews.llvm.org/D137669#3916493>, @mgorny wrote:

> Could you issue a warning though? It's really annoying when targets disappear like that and you have to guess which of the checks failed.

What about just making it an error if LLVM_INCLUDE_TESTS is set, but it kind find all the tools?  I also don't like the silent disabling of features, but I'm not sure how visible the warning would be to users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137669/new/

https://reviews.llvm.org/D137669



More information about the llvm-commits mailing list