[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:1528
+                ProcessorFeatures.TRMTuning>;
+def : ProcModel<"grandridge", SLMModel, ProcessorFeatures.GRRFeatures,
+                ProcessorFeatures.TRMTuning>;
----------------
RKSimon wrote:
> SLMModel explicitly doesn't have support for AVX/AVX2 - I think you should investigate forking SLMModel and creating a AlderlakeEModel for all of these
> 
> Also, should these be here or moved up below tremont and the other atom cores?
Yeah, SLMModel's coverage is not right here. From view of coverage, AlderlakePModel is better here. Maybe we could use AlderlakePModel first? When sierraforest and grandridge's instruction perf info is more detailed or we can test from a real machine, we can then add a new Model and replaced here. Same for SRFTuning and GRRTuning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137153/new/

https://reviews.llvm.org/D137153