[PATCH] D137368: [lld-macho] Overhaul map file code

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 16:23:11 PST 2022


thakis added a comment.

In D137368#3915933 <https://reviews.llvm.org/D137368#3915933>, @int3 wrote:

>> Does this allow us to undo D115416 <https://reviews.llvm.org/D115416>?
>
> Possibly, I'll have to do some benchmarks. However I think it is likely still a performance improvement to do it in parallel

Sure, but having simpler code makes it easier to parallelize other parts. Doing complicated parallelism too early makes it harder to do parallelize things that would otherwise be easier to parallelize and might get us stuck in a local optimum.

(This is admittedly very hand-wavy!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137368/new/

https://reviews.llvm.org/D137368



More information about the llvm-commits mailing list