[PATCH] D137676: [compiler-rt][hwasan] Do not call InitLoadedGlobals in __hwasan_init

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 15:23:21 PST 2022


mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: compiler-rt/lib/hwasan/hwasan.cpp:343
   InitInstrumentation();
+#if !SANITIZER_FUCHSIA
+  // Fuchsia's libc provides a hook (__sanitizer_module_loaded) that runs on the
----------------
You could make this an `if constexpr` instead of `#if` to avoid the unused static function warning.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137676/new/

https://reviews.llvm.org/D137676



More information about the llvm-commits mailing list