[PATCH] D133700: [PowerPC] Exploit xxperm, check for dead vectors and substitute vperm with xxperm
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 12:12:33 PST 2022
stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.
I think this looks good.
Thank you for addressing the comments!
LGTM
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10194
// the permutation mask is complemented with respect to 31. This is
- // necessary to produce proper semantics with the big-endian-biased vperm
+ // necessary to produce proper semantics with the big-endian-based vperm
// instruction.
----------------
nit:
`big-endian-based` -> `big-endian based`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133700/new/
https://reviews.llvm.org/D133700
More information about the llvm-commits
mailing list