[PATCH] D136201: [InstCombine] Handle PHI nodes when eliminating constant memcpy

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 marked 3 inline comments as done.
gandhi21299 added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/replace-alloca-phi.ll:3
+; RUN: opt -passes=instcombine -S -o - %s | FileCheck %s
+
+target triple="amdgcn-amd-amdhsa"
----------------
arsenm wrote:
> gandhi21299 wrote:
> > arsenm wrote:
> > > arsenm wrote:
> > > > Drop the triple, this just needs target datalayout ="A5". Otherwise this will fail without amdgpu built 
> > > Probably should do "p5-32-A5"
> > Is that a complete specification? I am getting the following error: 
> > 
> > `error: Missing size specification for pointer in datalayout string`
> > 
> target datalayout = "p5:32:32-A5"
> 
`isOnlyCopiedFromConstantMemory` seems to depend on AMDGPUAliasAnalysis results. It returns false for the tests I added when I replace the triple string with the datalayout you suggested.

cc @bcahoon 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136201/new/

https://reviews.llvm.org/D136201