[PATCH] D137625: [AArch64][SVE2] Add the SVE2.1 tbxq instruction

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:9369
+// Programmable table lookup within each quadword vector segment (merging)
+class sve2p1_tbxq<bits<2> sz, string mnemonic, ZPRRegOp zprty>
+    : I<(outs zprty:$Zd), (ins zprty:$_Zd, zprty:$Zn, zprty:$Zm),
----------------
CarolineConcatto wrote:
> I don't know how much should we re-use the old classes.
> but with some changes you could re-use class sve2_int_perm_tbx, no?
> let Inst{15-13} = 0b001; 
> let Inst{12-10} = op
> 
I agree, and by reusing the `sve2_int_perm_tbx` multiclass we can also easily add the code generation support once the intrinsic exists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137625/new/

https://reviews.llvm.org/D137625