[PATCH] D137553: [MemorySSA] Delete dead MemoryUseOrDef for CallInst when clone loop basicblock

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 08:54:47 PST 2022


StephenFan added a comment.

In D137553#3915015 <https://reviews.llvm.org/D137553#3915015>, @nikic wrote:

> I'm a bit unsure about the approach used here. Might it make more sense to relax the assertion instead? AA returning better (or worse!) results as a result of other transforms is pretty normal, so it seems fragile if code has to go out of the way to drop no longer needed MemoryAccesses to avoid assertion failures.

To be honest, I have the same concerns. I will try to relax the assertion instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137553/new/

https://reviews.llvm.org/D137553



More information about the llvm-commits mailing list