[PATCH] D137554: [AArch64][SVE2] Add the SVE2.1 quadword structured load/store instructions

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 08:46:36 PST 2022


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:7131-7132
   let Inst{24-23} = sz;
-  let Inst{22-21} = nregs;
-  let Inst{20}    = 0;
+  let Inst{22-21} = nregs{1-0};
+  let Inst{20}    = nregs{2};
   let Inst{19-16} = imm4;
----------------
Personally I would have kept it simple with `Inst{22-20} = nregs`, so that everything reads left to right, but there's nothing here I can't live with.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137554/new/

https://reviews.llvm.org/D137554



More information about the llvm-commits mailing list