[PATCH] D137587: [OpenMP][OMPIRBuilder] Migrate target outlined function registration to OMPIRBuilder from clang

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1379
+  void setOutlinedFunctionAttributes(Function *OutlinedFn, bool IsEmbedded,
+                                     int32_t NumTeams, int32_t NumThreads);
+
----------------
jdoerfert wrote:
> Outlined function is too generic for the function name here and elsewhere. It's an outlined target region, or similar. We outline a lot of functions but this is specific to target regions, correct?
> Outlined function is too generic for the function name here and elsewhere. It's an outlined target region, or similar. We outline a lot of functions but this is specific to target regions, correct?

Yes, I am replacing it with setOutlinedTargetRegionFunctionAttributes. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137587/new/

https://reviews.llvm.org/D137587