[PATCH] D137635: [CodeGen] Add sources to isVectorClearMaskLegal. NFC.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 06:58:22 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:23166
 
+        SDValue BitCastN0 = DAG.getBitcast(IntVT, N0);
+        SDValue ZeroInIntVT = DAG.getConstant(0, DL, IntVT);
----------------
How nasty would it be NOT to add the bitcast here at all and allow the N0/N1 operands into isVectorClearMaskLegal to keep their original types as long as they can safely be bitcasted to IntVT?

We'd still bitcast it as part of the getVectorShuffle call of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137635/new/

https://reviews.llvm.org/D137635



More information about the llvm-commits mailing list