[PATCH] D137626: [test] Avoid legacy PM default pipelines (O0, O1 etc) when running opt

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

Just a side not here.

As I wrote in the descrption: "I think that given this patch we get close to removing code related to 'AddOptimizationPasses' in opt.cpp."

I'm not sure exactly how fast we can/want to move forward. But I've assumed that we perhaps want to get rid of the legacy default pipelines.
But if we for example want to remove `PassManagerBuilder::populateModulePassManager` and `PassManagerBuilder::populateFunctionPassManager` there are some more uses (and I'm not aware of any ongoing work in deprecating those).

  clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:  Builder.populateModulePassManager(MPM);
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:  Builder->populateFunctionPassManager(*FPM);
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:  Builder->populateModulePassManager(*MPM);
  llvm/tools/bugpoint/bugpoint.cpp:  Builder.populateFunctionPassManager(FPM);
  llvm/tools/bugpoint/bugpoint.cpp:  Builder.populateModulePassManager(FPM);
  llvm/tools/opt/opt.cpp:  Builder.populateFunctionPassManager(FPM);
  llvm/tools/opt/opt.cpp:  Builder.populateModulePassManager(MPM);
  polly/lib/CodeGen/PPCGCodeGeneration.cpp:    PassBuilder.populateModulePassManager(OptPasses);

Where the uses PassManagerBuilder.cpp relate to `LLVMPassManagerBuilderPopulateFunctionPassManager `and `LLVMPassManagerBuilderPopulateModulePassManager`.

So even if we remove the support for O<n> in opt (for legacy PM) there are still uses around of the legacy PM:s module/function pipelines in OCAML, LLVM-C, Polly, bugpoint, clang-fuzzer and MCJITCAPITest.

I know that there exists a github issue about bugpoint. But no idea if there has been any tickets or RFC:s about remove legacy PM from the rest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137626/new/

https://reviews.llvm.org/D137626