[PATCH] D137613: [TypePromotion] Replace Zext to Truncate for the case src bitwidth is larger

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 04:56:33 PST 2022


bcl5980 added inline comments.


================
Comment at: llvm/test/Transforms/TypePromotion/AArch64/pr58843.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -type-promotion -verify -S %s -o - | FileCheck %s
----------------
samtebbs wrote:
> Since this is a midend change I think a target-agnostic test would be better.
This pass need some target-dependent informations like `RegisterBitWidth`, `TLI->getTypeAction(*Ctx, SrcVT)`.
And the crash can't  be reproduced on x86_64 and riscv64. So a target-agnostic test is a little tricky here I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137613/new/

https://reviews.llvm.org/D137613



More information about the llvm-commits mailing list