[PATCH] D137620: [BOLT] Don't align .text to pageAlign
Denis Revunov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 02:57:04 PST 2022
treapster added a comment.
In D137620#3914527 <https://reviews.llvm.org/D137620#3914527>, @yota9 wrote:
> In both cases we are loading from the same file offset the same amount of memory. Could you please give full sections headers before and after so I could compare them?
Oops, LOAD segment int "After" was wrong. Edited.
In D137620#3914506 <https://reviews.llvm.org/D137620#3914506>, @treapster wrote:
> Before patch
>
> PHDR 0x200000 0x0000000000200000 0x0000000000200000 0x0002a0 0x0002a0 R 0x8
> LOAD 0x200000 0x0000000000200000 0x0000000000200000 0x200404 0x200404 R E 0x200000
> ...
> [26] .text PROGBITS 0000000000400000 400000 0001b1 00 AX 0 0 2097152
>
> After
>
> PHDR 0x200000 0x0000000000200000 0x0000000000200000 0x0002a0 0x0002a0 R 0x8
> LOAD 0x200000 0x0000000000200000 0x0000000000200000 0x000744 0x000744 R E 0x200000
> ...
> [26] .text PROGBITS 0000000000200340 200340 0001b1 00 AX 0 0 64
>
> Offset is aligned with address, we just remove empty space both in file and in memory
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137620/new/
https://reviews.llvm.org/D137620
More information about the llvm-commits
mailing list