[PATCH] D137260: [AArch64InstPrinter] Print TargetAddress as an uint64_t

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 02:11:00 PST 2022


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. I was expecting a test using objdump or llc, but the new test looks good. It may be possible to replace StringStream, but otherwise LGTM.



================
Comment at: llvm/unittests/Target/AArch64/AArch64InstPrinterTest.cpp:35
+
+class StringStream : public raw_ostream {
+public:
----------------
Could this use raw_string_ostream?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137260/new/

https://reviews.llvm.org/D137260



More information about the llvm-commits mailing list