[PATCH] D137538: [SIFoldOperands] Move `isFoldableCopy` into a separate helper, NFC.
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 7 23:39:14 PST 2022
Pierre-vh added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFoldOperands.cpp:1819
+ if (TII->isFoldableCopy(MI)) {
+ Changed |= tryFoldFoldableCopy(MI, CurrentKnownM0Val);
continue;
----------------
foad wrote:
> Personally I would prefer to make CurrentKnownM0Val a field of SIFoldOperands, rather than pass in a reference to a local variable. But perhaps that is overkill.
It may be a good idea but then it should be done as a separate patch IMO
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137538/new/
https://reviews.llvm.org/D137538
More information about the llvm-commits
mailing list