[llvm] 9d96feb - [SLP][NFC] Restructure areTwoInsertFromSameBuildVector

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 20:04:13 PST 2022


Author: skc7
Date: 2022-11-08T09:32:19+05:30
New Revision: 9d96feb19b57526eca19cf6e27e61b8028a4bffc

URL: https://github.com/llvm/llvm-project/commit/9d96feb19b57526eca19cf6e27e61b8028a4bffc
DIFF: https://github.com/llvm/llvm-project/commit/9d96feb19b57526eca19cf6e27e61b8028a4bffc.diff

LOG: [SLP][NFC] Restructure areTwoInsertFromSameBuildVector

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D137569

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index ba44d4a77ca3..ac2397beb492 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -7153,8 +7153,10 @@ static bool areTwoInsertFromSameBuildVector(
     return false;
   auto *IE1 = VU;
   auto *IE2 = V;
-  unsigned Idx1 = *getInsertIndex(IE1);
-  unsigned Idx2 = *getInsertIndex(IE2);
+  Optional<unsigned> Idx1 = getInsertIndex(IE1);
+  Optional<unsigned> Idx2 = getInsertIndex(IE2);
+  if (Idx1 == None || Idx2 == None)
+    return false;
   // Go through the vector operand of insertelement instructions trying to find
   // either VU as the original vector for IE2 or V as the original vector for
   // IE1.
@@ -7165,14 +7167,14 @@ static bool areTwoInsertFromSameBuildVector(
       return V->hasOneUse();
     if (IE1) {
       if ((IE1 != VU && !IE1->hasOneUse()) ||
-          getInsertIndex(IE1).value_or(Idx2) == Idx2)
+          getInsertIndex(IE1).value_or(*Idx2) == *Idx2)
         IE1 = nullptr;
       else
         IE1 = dyn_cast_or_null<InsertElementInst>(GetBaseOperand(IE1));
     }
     if (IE2) {
       if ((IE2 != V && !IE2->hasOneUse()) ||
-          getInsertIndex(IE2).value_or(Idx1) == Idx1)
+          getInsertIndex(IE2).value_or(*Idx1) == *Idx1)
         IE2 = nullptr;
       else
         IE2 = dyn_cast_or_null<InsertElementInst>(GetBaseOperand(IE2));


        


More information about the llvm-commits mailing list