[PATCH] D137601: Only hash the start of keys in StringMap

Jamie Hill-Daniel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 7 17:06:11 PST 2022


clubby789 added inline comments.


================
Comment at: llvm/lib/Support/StringMap.cpp:87
     init(16);
-  unsigned FullHashValue = djbHash(Name, 0);
+  unsigned FullHashValue = djbHash(Name.take_front(1024), 0);
   unsigned BucketNo = FullHashValue & (NumBuckets - 1);
----------------
1024 was chosen arbitrarily and different numbers may give a better tradeoff between collisions and hash time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137601/new/

https://reviews.llvm.org/D137601



More information about the llvm-commits mailing list