[PATCH] D135402: [LLD] Enable --no-undefined-version by default.

Mon Nov 7 17:05:14 PST 2022

MaskRay added a comment.

In D135402#3913787 <https://reviews.llvm.org/D135402#3913787>, @ronlieb wrote:

> my build systems have ROCm installed, which might make a difference.
>  since i can reproduce the issue locally
>
>   ld.lld: error: openmp/runtime/src/CMakeFiles/omp.dir/kmp_csupport.cpp.o: symbol ompc_set_affinity_format@@VERSION has undefined version VERSION
>
> i would like to request the change be reverted so we can restore the bot to green, and work the issue locally , and push up a patch sometime tomorrow to attempt to resolve for our bot.
>
> are you seeing any other bots failing from this change ?

I am ok with a temporary revert.

The first revert was done nearly a month ago but no action was taken to properly fix the issue 88da0de14f135bee034b286cc736dacd6274e77d <https://reviews.llvm.org/rG88da0de14f135bee034b286cc736dacd6274e77d>. I wish that OpenMP folks can fix this properly:)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135402/new/

https://reviews.llvm.org/D135402