[PATCH] D137204: [flang] Add check for constraints on event-stmts

Mon Nov 7 16:14:52 PST 2022

ktras added inline comments.

================
Comment at: flang/include/flang/Evaluate/tools.h:1202-1203
 bool IsBuiltinCPtr(const Symbol &);
+bool IsEventType(const DerivedTypeSpec *);
+bool IsLockType(const DerivedTypeSpec *);
 // Is this derived type TEAM_TYPE from module ISO_FORTRAN_ENV?
----------------
PeteSteinfeld wrote:
> Is Evaluate/tools.h the right place for these functions?
> 
> Note that the function `IsOrContainsEventOrLockComponent()` is in Semantics/tools.h.  It also looks like all references to these functions come from within the Semantics directory.  Putting them all in the same files and directory makes more sense to me.
Thanks for the feedback. I put these new functions in `Evaluate/tools.h` since `IsTeamType` and `IsEventTypeOrLockType` are both there. I don't have a strong feeling where they should go, but if I move the new functions, then I think those other functions should probably also be moved. What do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137204/new/

https://reviews.llvm.org/D137204