[PATCH] D137590: [CodeGen][AArch64] Enable LDAPR under +RCPC
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 7 14:53:03 PST 2022
alexander-shaposhnikov marked an inline comment as done.
alexander-shaposhnikov added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/arm64-atomic.ll:7
-; RUN: llc < %s -mtriple=arm64-apple-ios -global-isel -global-isel-abort=1 -mattr=+rcpc,+ldapr -verify-machineinstrs | FileCheck %s --check-prefixes=CHECK-LDAPR-O1
-; RUN: llc < %s -mtriple=arm64-apple-ios -global-isel -global-isel-abort=1 -mattr=+rcpc,+ldapr -O0 -verify-machineinstrs | FileCheck %s --check-prefixes=CHECK-LDAPR-O0
----------------
efriedma wrote:
> Why are you dropping these tests, as opposed to just removing the "+ldapr" from the RUN line? Are they redundant with some other existing tests?
yes, they are redundant (already covered by the invocations above, see e.g. line 1221 CHECK-LSE-O1-NEXT: ldaprb)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137590/new/
https://reviews.llvm.org/D137590
More information about the llvm-commits
mailing list