[PATCH] D137440: [RISCV][llvm-mca] Use LMUL Instruments to provide more accurate reports on RISCV

[Michael Maitland via Phabricator via llvm-commits]

michaelmaitland updated this revision to Diff 473798.
michaelmaitland added a comment.

- Updated docs
- Made fields in `Instrument` private
- Improved classdoc for `InstrumentManager`
- Removed `llvm` namespace qualifier where it wasn't needed
- Simplified `Instrument` default constructor
- Use `StringSwitch` in `RISCVCustomBehaviour`
- Use `==` instead of `.equals` on StringRefs
- add `const` qualifier on `MCACommentConsumer::hadErr`

With respect to the request that tests are added:

There is no RISCV vector scheduler model that exists upstream. As a result, any tests I would add
will fail because processor does not support the vector instructions. I propose that we should create
a generic RISCV vector processor that exists upstream in a seperate patch. I think that this
would be beneficial for MCA so I can include those tests, but also for llvm contributors in areas
such as academia. What do you think about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137440/new/

https://reviews.llvm.org/D137440

Files:
  llvm/docs/CommandGuide/llvm-mca.rst
  llvm/include/llvm/MC/TargetRegistry.h
  llvm/include/llvm/MCA/CustomBehaviour.h
  llvm/include/llvm/MCA/InstrBuilder.h
  llvm/lib/MCA/CustomBehaviour.cpp
  llvm/lib/MCA/InstrBuilder.cpp
  llvm/lib/Target/RISCV/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/CMakeLists.txt
  llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
  llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.h
  llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
  llvm/tools/llvm-mca/CodeRegion.cpp
  llvm/tools/llvm-mca/CodeRegion.h
  llvm/tools/llvm-mca/CodeRegionGenerator.cpp
  llvm/tools/llvm-mca/CodeRegionGenerator.h
  llvm/tools/llvm-mca/llvm-mca.cpp
  llvm/unittests/tools/llvm-mca/MCATestBase.cpp
  llvm/unittests/tools/llvm-mca/X86/TestIncrementalMCA.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137440.473798.patch
Type: text/x-patch
Size: 60336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/34f950b5/attachment.bin>