[PATCH] D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job.

[Ying Yi via Phabricator via llvm-commits]

MaggieYi updated this revision to Diff 473788.
MaggieYi added a comment.

Updated the patch following reviewers' comments:

1. Modified the format of the message including the number of files in the limit and the actual number of files that caused the limit to be exceeded.
2. Corrected variable names since LLVM uses 'SamelCase' variable names.
3. Since warnings are moved from 'lld' to 'llvm/support', used llvm 'WithColor::warning()' (instead of lld 'warn()') to generate the warning.
4. Simplified the tests using shell substitution via $().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135590/new/

https://reviews.llvm.org/D135590

Files:
  lld/COFF/LTO.cpp
  lld/ELF/LTO.cpp
  lld/MachO/LTO.cpp
  lld/test/COFF/lto-cache-warnings.ll
  lld/test/ELF/lto/cache-warnings.ll
  lld/test/MachO/lto-cache-warnings.ll
  lld/test/wasm/lto/cache-warnings.ll
  lld/wasm/LTO.cpp
  llvm/include/llvm/Support/CachePruning.h
  llvm/lib/LTO/ThinLTOCodeGenerator.cpp
  llvm/lib/Support/CachePruning.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135590.473788.patch
Type: text/x-patch
Size: 20638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221107/9ebd4b44/attachment.bin>